Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
@taylorotwell
taylorotwell committed Mar 9, 2018
1 parent 972b82a commit 67d8a4b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Illuminate/Support/Carbon.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static function serializeUsing($callback)
* @param array $array
* @return static
*/
public static function __set_state($array)
public static function __set_state(array $array)
{
return static::instance(parent::__set_state($array));
}
Expand Down

12 comments on commit 67d8a4b

@austenc
Copy link
Contributor

@austenc austenc commented on 67d8a4b Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 🎉

@olafnorge
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The carbon guys fixed it the right way https://github.com/briannesbitt/Carbon/pull/1172/files

@olafnorge
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please roll that back?

@MiniCodeMonkey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yeah, this needs to be rolled back again now that Carbon rolled their change back. I'm just getting a compatibility warning the other way around now ErrorException (E_WARNING) Declaration of Illuminate\Support\Carbon::__set_state(array $array) should be compatible with Carbon\Carbon::__set_state($state)

@MiniCodeMonkey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy 1

@c-sakel
Copy link

@c-sakel c-sakel commented on 67d8a4b Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbehnke
Copy link

@mbehnke mbehnke commented on 67d8a4b Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php artisan down

In Carbon.php line 9:

Declaration of Illuminate\Support\Carbon::__set_state(array $array) should be compatible with Carbon\Carbon::__set_state($state)

@ptuchik
Copy link

@ptuchik ptuchik commented on 67d8a4b Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for rollback 🤣

@devcircus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now in 5.6.11

@ptuchik
Copy link

@ptuchik ptuchik commented on 67d8a4b Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about 5.5.x?

@devcircus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New 5.5 has been tagged as well

@ptuchik
Copy link

@ptuchik ptuchik commented on 67d8a4b Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!! Thanks

Please sign in to comment.