Restrict comparison against hardcoded integers

laravel · May 3, 2018 · 47580bf · 47580bf
1 parent 411fc1d
commit 47580bf
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
@@ -458,7 +458,7 @@ public function validateGt($attribute, $value, $parameters)
 
         $comparedToValue = $this->getValue($parameters[0]);
 
-        if (is_null($comparedToValue) && is_numeric($parameters[0])) {
+        if (is_null($comparedToValue) && (is_numeric($value) && is_numeric($parameters[0]))) {
             return $this->getSize($attribute, $value) > $parameters[0];
         }
 
@@ -481,7 +481,7 @@ public function validateLt($attribute, $value, $parameters)
 
         $comparedToValue = $this->getValue($parameters[0]);
 
-        if (is_null($comparedToValue) && is_numeric($parameters[0])) {
+        if (is_null($comparedToValue) && (is_numeric($value) && is_numeric($parameters[0]))) {
             return $this->getSize($attribute, $value) < $parameters[0];
         }
 
@@ -504,7 +504,7 @@ public function validateGte($attribute, $value, $parameters)
 
         $comparedToValue = $this->getValue($parameters[0]);
 
-        if (is_null($comparedToValue) && is_numeric($parameters[0])) {
+        if (is_null($comparedToValue) && (is_numeric($value) && is_numeric($parameters[0]))) {
             return $this->getSize($attribute, $value) >= $parameters[0];
         }
 
@@ -527,7 +527,7 @@ public function validateLte($attribute, $value, $parameters)
 
         $comparedToValue = $this->getValue($parameters[0]);
 
-        if (is_null($comparedToValue) && is_numeric($parameters[0])) {
+        if (is_null($comparedToValue) && (is_numeric($value) && is_numeric($parameters[0]))) {
             return $this->getSize($attribute, $value) <= $parameters[0];
         }