[1.x] Fix double error message for failed 2FA response #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix 🙌 , though please mention these breaking changes in the changelog 😅 We're always missing them for Fortify because they're included in minor releases, resulting in views not working or error messages not being displayed. In this case we were only displaying the error for |
|
@sebastiaanluca yes sorry about that. We really try to minimize these... unfortunately this was a necessary one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue where a failed message was shown twice. This is technically a breaking change since we're removing the email key (the reason why we didn't in the related PR below). But the correct key is
code.See #360