[2.x] Dispatch Event when Two Factor Challenged #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelbutcher
pushed a commit
to joelbutcher/fortify
that referenced
this pull request
Jan 7, 2022
* dispatch event when two factor challenged and test * use statements styleci (cherry picked from commit b490728)
taylorotwell
pushed a commit
that referenced
this pull request
Jan 7, 2022
* [2.x] Events for Two Factor Authentication (#162) * added events * dispatch events * added tests for events * Style CI fixes * rename events * fix usages (cherry picked from commit 8105a1a) * [2.x] Dispatch Event when Two Factor Challenged (#239) * dispatch event when two factor challenged and test * use statements styleci (cherry picked from commit b490728) Co-authored-by: danclaytondev <daniel@cl8on.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons it is a good idea to log when a user successfully uses their credentials, and is two factor challenged, particularly when the 2nd factor is not passed, which suggests a password has been compromised.
This is summarised by the OWASP here.
This PR continues what has been merged from #162 and adds the event and modifies a test to check it is dispatched.