Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.13] Compatibility with PHPUnit ~6.0 #227

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

deleugpn
Copy link
Contributor

@deleugpn deleugpn commented Apr 18, 2017

This closes #99. Although it looks a breaking change, it actually isn't. If someone is overriding the setUp method, they're already calling the parent from within it otherwise the application doesn't work. This change only adds one more step to the setUp.

[dusk@php7 dusk-with-unit]$ php artisan serve &
[1] 2538
[dusk@php7 dusk-with-unit]$ Laravel development server started: <http://127.0.0.1:8000>

[dusk@php7 dusk-with-unit]$
[dusk@php7 dusk-with-unit]$ php artisan dusk
PHPUnit 6.1.0 by Sebastian Bergmann and contributors.

[Tue Apr 18 14:43:08 2017] 127.0.0.1:51566 [200]: /favicon.ico
.                                                                   1 / 1 (100%)

Time: 2.03 seconds, Memory: 10.00MB

OK (1 test, 1 assertion)

@taylorotwell taylorotwell merged commit 4dd4331 into laravel:master Apr 18, 2017
@deleugpn deleugpn deleted the PHPUnit-6 branch April 18, 2017 20:28
@deleugpn deleugpn changed the title Compatibility with PHPUnit ~6.0 [1.0.13] Compatibility with PHPUnit ~6.0 Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants