Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable smooth scrolling in TestCase #1167

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

ziadoz
Copy link
Contributor

@ziadoz ziadoz commented Feb 20, 2025

My colleague @MizouziE tracked down that this behaviour can be the source of flaky test failures, particularly in CI. We turned this flag on a few months ago, and it's reduced our intermittent CI test failures significantly.

The flag is documented here: https://peter.sh/experiments/chromium-command-line-switches/#disable-smooth-scrolling

The type of failures we've found it helps with are ones like this, when locating the element involves scrolling:

NoSuchElementException: no such element: Unable to locate element: {"method":"css selector","selector":"body #foo-bar"}

ziadoz and others added 2 commits February 20, 2025 12:26
https: //peter.sh/experiments/chromium-command-line-switches/#disable-smooth-scrolling
Co-Authored-By: Sam <90829439+mizouzie@users.noreply.github.com>
@taylorotwell taylorotwell merged commit bb70183 into laravel:8.x Feb 20, 2025
42 checks passed
@taylorotwell
Copy link
Member

Awesome - thanks

@ziadoz ziadoz deleted the no-smooth-scrolling branch February 20, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants