[12.x] Move comment to Torchlight code fence filename attribute #9972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this on my machine
|
|
Yeah, I also noticed that there's some stuff missing. Weird package 🤔 @nunomaduro also had to add some CSS when he did laravel/laravel.com#318 |
|
@taylorotwell Do I take it that it's worth putting effort into that? |
|
I added the missing CSS via laravel/laravel.com#366, so this PR can be merged as soon as the other one at |
shaedrich
changed the title
|
@taylorotwell Since the docs are now reworked for 12.x via #10188, we can give this one another shot according to your comment in laravel/laravel.com#366 (comment), shall we? |
shaedrich
changed the title
|
I think I'll just leave it for now. |
|
And you needed over a quarter of a year to realize that? Wow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Torchlight code fence
filenameattributeShould the filenames start with a
/?