Skip to content

[10.x] Make invokable rules default #8165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2022
Merged

[10.x] Make invokable rules default #8165

merged 1 commit into from
Aug 29, 2022

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Aug 26, 2022 •
edited
Loading

See: laravel/framework#43868

Warning: This is a change that should likely be recorded in the Upgrade Guide for 10.x.

@timacdonald timacdonald mentioned this pull request Aug 26, 2022
Merged
@taylorotwell taylorotwell merged commit eb6c3ed into laravel:master Aug 29, 2022
@timacdonald timacdonald deleted the make-invokable-rules-default branch August 29, 2022 22:47
@Synchro
Copy link
Contributor

Synchro commented Apr 6, 2023 •
edited
Loading

I see this was merged ages ago, and note that my implementations of InvokableRule are marked as deprecated – but the docs still say:

A rule object contains a single method: validate.

Why is that?

@Synchro
Copy link
Contributor

Synchro commented Apr 11, 2023

Never mind, I see that this was changed again not long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timacdonald @Synchro @taylorotwell