Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Added docs for 'throw' method #7876

Closed
wants to merge 1 commit into from

Conversation

ash-jc-allen
Copy link
Contributor

@ash-jc-allen ash-jc-allen commented Apr 13, 2022

Hi! This PR is only a small one and just adds a small explainer for the throw method adding to the Http facade today in laravel/framework#41953.

Hopefully, it's all okay and get's the general idea across of how to use the method 😄

@taylorotwell taylorotwell marked this pull request as draft April 15, 2022 14:57
@taylorotwell
Copy link
Member

Drafting until release day.

@laravel laravel deleted a comment from laurentrousseau918 Apr 19, 2022
@taylorotwell taylorotwell marked this pull request as ready for review April 19, 2022 15:03
@taylorotwell
Copy link
Member

I think I'll just leave this out of the docs for now.

@ash-jc-allen ash-jc-allen deleted the http-throw-docs branch April 19, 2022 15:12
@ash-jc-allen
Copy link
Contributor Author

That's no problem at all :)

@sebastiaanluca
Copy link

Just my 2 cents, but having this in the documentation would be useful though. I'd rather indicate errors should be thrown before sending a request. Already updated all my code to use the new functionality 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants