[5.7] Document contextual binding unavailability for method injection #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'm just going to avoid documenting this for now to be honest. I think it's a little complicated and it's simpler to just pass any primitive dependencies through the constructor. |
|
@taylorotwell re-opened this with the changes we discussed. |
driesvints
changed the title
|
Went ahead and just added the |
|
@taylorotwell haha no worries. Thanks for adding it! |
|
If someone's interested in the feature, I've created a package that let us use method bindings with ease: I also plan to extend the package functionality in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method injection sent in by Adam here wasn't documented yet. I've also added a note that contextual binding isn't supported for this because this was causing some confusion. See laravel/framework#23602