Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
LoginRequest
to use the requestboolean()
method instead offilled()
when determining if the user should be remembered.The primary issue with
filled()
is that it will returntrue
ifremember
isfalse
(in a JSON request). This is common when working with Inertia where you have a booleanremember
data value.Using
boolean()
works for the Blade approach as well, since the underlyingFILTER_VALIDATE_BOOLEAN
check returnstrue
for the value"on"
.