Vue code formatting #212
Merged
Vue code formatting #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimani-dev
pushed a commit
to slimani-dev/breeze
that referenced
this pull request
Jan 21, 2023
* Configure StyleCI to format Vue files * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting in the Vue stubs had become a little inconsistent because we don't have a formatter enabled for them. We're using StyleCI for PHP, JS, JSX, and CSS, so this PR enables it for Vue files as well.
I believe StyleCI uses Prettier under the hood for Vue files, so this should improve the out-of-box experience for developers using Prettier as they can now prevent their editors from making large unrelated changes as they start to tweak their Breeze installation.
This code style also allows us to run Tailwind's Prettier plugin to apply their recommended class order (it's not possible to run the plugin without making other changes). However, I haven't included that in this PR because I couldn't get it to work on the Blade stubs 😢