Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse fake dates into Carbon objects #676

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

jasonmccreary
Copy link
Collaborator

@jasonmccreary jasonmccreary commented Feb 29, 2024

Currently, Blueprint uses Faker dates for columns with a date data type. This either generates you a string or a DateTimeInterface object. Neither of these are readily useable for testing.

This PR parses the returned faker data into an Illuminate\Support\Carbon object. This allows it to be used more readily in tests.

@laravel-shift laravel-shift force-pushed the fix-date-format-in-tests branch from 2aa06a5 to 611b697 Compare February 29, 2024 15:17
@laravel-shift laravel-shift force-pushed the fix-date-format-in-tests branch from 611b697 to da6b458 Compare February 29, 2024 15:24
@jasonmccreary jasonmccreary changed the title Handle dates as Carbon objects Parse fake dates into Carbon objects Feb 29, 2024
@jasonmccreary jasonmccreary merged commit 92c7b72 into master Feb 29, 2024
27 checks passed
@jasonmccreary jasonmccreary deleted the fix-date-format-in-tests branch February 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant