Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous softDeletes & softDeletesTz columns #592

Merged
merged 7 commits into from
Jan 5, 2023
Merged

Remove superfluous softDeletes & softDeletesTz columns #592

merged 7 commits into from
Jan 5, 2023

Conversation

ghostwriter
Copy link
Contributor

Resolves #585 and closes #590

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@@ -637,7 +637,7 @@ public function output_generates_constraint_for_uuid()
/**
* @test
*/
public function output_respects_softdelete_order()
public function output_softdelete_column_last()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄‍♂️

@jasonmccreary jasonmccreary merged commit 3185ee4 into laravel-shift:master Jan 5, 2023
@ghostwriter ghostwriter deleted the bugfix/form-requests-excludes-softdeletes branch January 5, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants