This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Allow notification routing to depend on notification being sent #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the feature added in Laravel 5.6 for routing based on the notification being sent (laravel/framework#22289).
|
Cool, wasn't aware of this. I assume this isn't a breaking change because PHP will just ignore extra method arguments if they're not defined. |
|
Awesome - thanks for the quick merge, @dwightwatson! Any chance we can get an updated release for this and the APN package pushed sometime today? I was working on just creating my own duplicate classes and changing the method myself until these packages were updated, but that would save a ton of time! |
|
Just pushed a minor release for you - both APN and GCM. Let me know if you run into any issues. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the feature added in Laravel 5.6 for routing based on the notification being sent.
The merged PR is here