Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new error blade directive #68

Merged

Conversation

dakira
Copy link
Contributor

@dakira dakira commented Oct 2, 2019

Laravel 5.8.13 introduced a new blade directive that cleans up the error handling. It's used in the laravel/ui blade templates, so it would be nice if the tailwind-presets used it, too.

@edgrosvenor
Copy link

This is kind of a high priority pull request, I think, because the existing templates result in errors being thrown in Laravel 6.x. I don't remember seeing any documentation about a breaking change around the old $error->has() stuff, but the $error object appears to be missing. I solved it on my own site by manually changing to the new directive much like this pull request does.

@michaeldyrynda michaeldyrynda merged commit da3b9eb into laravel-frontend-presets:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants