Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker theme customization #25

Closed
mauthi opened this issue Mar 28, 2018 · 3 comments
Closed

Datepicker theme customization #25

mauthi opened this issue Mar 28, 2018 · 3 comments

Comments

@mauthi
Copy link
Contributor

mauthi commented Mar 28, 2018

This is a feature request.

Description

see laravel-enso/localisation#36

@aocneanu wrote: For the themes, we were also considering an approach, but please open a new ticket. Note that right now datepicker is a part of formbuilder (package). In the future we will created a dedicated npm / github package for this.

Expected behavior

Theme of datepicker can be defined for a project (based on choosen theme)

Actual behavior

flatpickr/dist/themes/material_green.css is used for datepicker

@aocneanu
Copy link
Member

I studied this topic, and the best solution that I see is to integrate the flatpickr css in our current themes. This way, when we set a dark theme, we will have the dark pickr, for the ones with green the green pickr and so on.

So what I'm saying is basically matching the existing bulmaswatch themes with the ones from the picker.

If someone overwrites the loaded theme in a project, than he will have only that one for the whole project.

@mauthi
Copy link
Contributor Author

mauthi commented Mar 30, 2018

I think we need to recompile themes after the update?
So you should maybe add the following to changelog?

  • uncomment lines 18-38 in webpack.mix.js
  • compile
  • comment lines 18-38 in webpack.mix.js

@aocneanu
Copy link
Member

You are right, I missed that. I will at the next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants