Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hrefのXSSを防ぐaタグを作成 #30

Merged
merged 3 commits into from
Apr 23, 2020
Merged

hrefのXSSを防ぐaタグを作成 #30

merged 3 commits into from
Apr 23, 2020

Conversation

tkow
Copy link
Contributor

@tkow tkow commented Apr 22, 2020 •
edited
Loading

概要

相談したいこと

  • コンポーネントの名前はProtectedLinkで認知しやすいかどうか
  • validatorがsetUp（mounted）の前に走るので、propsにアクセスできないので、force=trueであってもdebugで警告が出てしまうのを許容しても良いかどうか

その他参考

@tkow tkow requested a review from nasum April 22, 2020 08:34
nasum
nasum approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@nasum nasum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkow 大丈夫だと思います。LGTM！！

@nasum nasum merged commit 589b9d4 into master Apr 23, 2020
@nasum nasum deleted the feature/protected-link branch April 23, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasum nasum nasum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkow @nasum