perf: enhance efficiency in accessing slices

close #4
lanseyujie · Apr 30, 2024 · bbf87f1 · bbf87f1
1 parent ce85522
commit bbf87f1
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/wssh/wssh.go b/wssh/wssh.go
@@ -115,7 +115,7 @@ func requestPty(sess *ssh.Session, cols, rows int) error {
 	return err
 }
 
-func (w *WebSocketShell) Send(ws *websocket.Conn, reader io.Reader) (err error) {
+func (w *WebSocketShell) Send(ws *websocket.Conn, reader io.Reader) error {
 	buf := w.pool.Get().([]byte)
 	defer func() {
 		buf = buf[:0]
@@ -124,14 +124,14 @@ func (w *WebSocketShell) Send(ws *websocket.Conn, reader io.Reader) (err error)
 
 	buf = make([]byte, cap(buf))
 	buf[0] = byte(SESSION)
-	_, err = reader.Read(buf[1:])
+	n, err := reader.Read(buf[1:])
 	if err != nil {
-		return
+		return err
 	}
 
-	err = websocket.Message.Send(ws, buf)
+	err = websocket.Message.Send(ws, buf[:n+1])
 
-	return
+	return err
 }
 
 func (w *WebSocketShell) Receive(ws *websocket.Conn, session *ssh.Session, writer io.WriteCloser) (err error) {