Add a ${username} variable for use in targets #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 87.8% 87.95% +0.14%
==========================================
Files 1 1
Lines 164 166 +2
Branches 19 20 +1
==========================================
+ Hits 144 146 +2
Misses 14 14
Partials 6 6
Continue to review full report at Codecov.
|
languitar
reviewed
Apr 16, 2019
|
Thanks for the PR. I wonder whether there are other tools that also set this, but anyways. I've added a single comment to the PR. After resolving that issue, I'm fine with merging this. |
In git-send-email, it requests a credential with a host and a username.
Normally this would be fine, but it can cause issues if you have
multiple email accounts on a single host (ex. multiple gmail accounts;
pass-git-helper sees them all as host=smtp.gmail.com:587). Having a
${username} (the variable matching the username requested) fixes this.
|
I've resolved it, I believe I left that duplicate conditional in while I was testing things. I've amended the commit. |
|
sorry for the long delay. finally merged |
|
On 6/13/19 3:19 PM, Johannes Wienke wrote:
sorry for the long delay. finally merged
All good. Thanks :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In git-send-email, it requests a credential with a host and a username.
Normally this would be fine, but it can cause issues if you have
multiple email accounts on a single host (ex. multiple gmail accounts;
pass-git-helper sees them all as host=smtp.gmail.com:587). Having a
${username} (the variable matching the username requested) fixes this.