Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stream for Gemini #8678

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

AAEE86
Copy link
Contributor

@AAEE86 AAEE86 commented Sep 23, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #8652

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@AAEE86 AAEE86 changed the title Add stream for Gemini add stream for Gemini Sep 23, 2024
@AAEE86 AAEE86 changed the title add stream for Gemini feat: add stream for Gemini Sep 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@crazywoola crazywoola merged commit 9a4b53a into langgenius:main Sep 26, 2024
6 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
@CXwudi
Copy link
Contributor

CXwudi commented Sep 27, 2024

@AAEE86 Is it my issue that I am getting this error
image

@AAEE86
Copy link
Contributor Author

AAEE86 commented Oct 3, 2024

@CXwudi 在config_kwargs中设置

config_kwargs.pop("stream", None)

虽然能解决报错问题,但是仍然不是流模式,代码_handle_generate_stream_response似乎有问题

@AAEE86 AAEE86 deleted the Add-stream-for-Gemini branch October 21, 2024 09:03
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to stream for Gemini.
3 participants