Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug tts(stream) not work on ios safari(17.1+) #8645

Conversation

likenamehaojie
Copy link
Contributor

@likenamehaojie likenamehaojie commented Sep 22, 2024

when work on tts stream model,the ManagedMediaSource(ios 17.1+). the audio api must set disableRemotePlayback = true
controls = true

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

when TTS(stream) work on ios safari webkit the audio cannot play .

Fixes

Type of Change

Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

when work on  tts stream model,the ManagedMediaSource(ios 17.1+).  the audio api must set 
disableRemotePlayback = true
controls = true
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Sep 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@crazywoola crazywoola merged commit 52da5b1 into langgenius:main Sep 23, 2024
3 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants