Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the 'inputs' field in /chat-messages takes effect every time #7955

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

Wu-Jiayang
Copy link
Contributor

@Wu-Jiayang Wu-Jiayang commented Sep 4, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Close #7952
Close #7846
Close #8063
Close #8839
Close #8546
Close #10522
Close #10055
Close #10643
Close #13363

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Sep 4, 2024
@crazywoola crazywoola requested a review from takatost September 4, 2024 04:48
@cubxxw
Copy link

cubxxw commented Sep 9, 2024

This PR does not resolve, using the conversation id to link to previous sessions but the input works

@Wu-Jiayang
Copy link
Contributor Author

This PR does not resolve, using the conversation id to link to previous sessions but the input works

I don't understand "using the conversation id to link to previous sessions but the input works". As for "This PR does not resolve", I have tried and I think it works.

@Wu-Jiayang
Copy link
Contributor Author

This PR does not resolve, using the conversation id to link to previous sessions but the input works

This PR is to make sure the 'inputs' field in the API "/chat-messages" takes effect every time, is that what you mean "using the conversation id to link to previous sessions but the input works"?

@cubxxw
Copy link

cubxxw commented Sep 10, 2024

Yes, you mean that the input field of the conversation can be updated under the same conversation, because the input is only effective when the conversation link is first established

@Wu-Jiayang
Copy link
Contributor Author

Yes, you mean that the input field of the conversation can be updated under the same conversation, because the input is only effective when the conversation link is first established

@cubxxw

I noticed that both table 'messages' and table 'conversations' have an 'inputs' field. I think the 'inputs' field should be aligned with table 'messages'. The 'inputs' field in table 'conversations' may not be very useful.

In this PR, the 'inputs' field in table 'conversations' means the 'inputs' in the first message, and the 'inputs' field in table 'messages' means the true inputs in this message.

@Wu-Jiayang
Copy link
Contributor Author

This PR does not resolve, using the conversation id to link to previous sessions but the input works

What's the mean of 'This PR does not resolve'? Is that any problems?

@cubxxw
Copy link

cubxxw commented Sep 10, 2024

#8063

This is the problem I encountered,

maybe I understand wrong, this PR can't solve the problem of the video in issue?

@cubxxw
Copy link

cubxxw commented Sep 10, 2024

I understand that the conversation table input is valid for the first time. The message table is used for every subsequent interaction, right?

@Wu-Jiayang
Copy link
Contributor Author

#8063

This is the problem I encountered,

maybe I understand wrong, this PR can't solve the problem of the video in issue?

This PR can solve the problem of the video in issue. @cubxxw

2024-09-10.16-19-57.mp4

@Wu-Jiayang
Copy link
Contributor Author

I understand that the conversation table input is valid for the first time. The message table is used for every subsequent interaction, right?

right

Copy link
Contributor

@Hisir0909 Hisir0909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent changes, making the workflow much more flexible.

@cubxxw
Copy link

cubxxw commented Oct 17, 2024

I think it's great, too

Hope to support this feature

@liuzixiao666
Copy link

Has this feature not been merged?

@Wu-Jiayang
Copy link
Contributor Author

Has this feature not been merged?

I don't know why they don't merge it, maybe we need more people to push them.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 11, 2024
@liuzixiao666
Copy link

liuzixiao666 commented Nov 11, 2024

Author

I highly appreciate your functionality and have submitted a new issue. If they do not merge, I will download your branch
https://github.com/langgenius/dify/issues/10522
#10522

@vsEcho567
Copy link

any update ?

@Wu-Jiayang
Copy link
Contributor Author

@abnormalboy
Copy link

i need this pr

@cubxxw
Copy link

cubxxw commented Feb 7, 2025

Happy New Year, but what?

@Wu-Jiayang
Copy link
Contributor Author

Happy New Year, everybody! @crazywoola @takatost @laipz8200 @iamjoel @JohnJyong @zxhlyh

@crazywoola
Copy link
Member

I'll revisit this with the team later, but we probably won't be releasing a minor update anytime soon, and we're working on a 1.0 update.

@crazywoola crazywoola self-assigned this Feb 8, 2025
@Wu-Jiayang
Copy link
Contributor Author

We've already been waiting for five months, and we don't mind waiting a little longer, as long as it won't be another five months.
^_^

@liuzixiao666
Copy link

We've already been waiting for five months, and we don't mind waiting a little longer, as long as it won't be another five months. ^_^

hhhhhhhhhhhhhhhhhhh,maybe 5 years

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 8, 2025
@deific
Copy link

deific commented Feb 8, 2025

LGTM

@Wu-Jiayang
Copy link
Contributor Author

when to merge?

@cubxxw
Copy link

cubxxw commented Feb 9, 2025

If we don't merge, I wonder if there's any way to add the DeepSeek R1 model. The current code is not easy to update.?

@laipz8200
Copy link
Member

If we don't merge, I wonder if there's any way to add the DeepSeek R1 model. The current code is not easy to update.?

This PR is not about the deepseek models, we provider many integrations of deepseek in the 0.15.3 version.

Check the release note.

@dc-vin
Copy link

dc-vin commented Feb 10, 2025

If we don't merge, I wonder if there's any way to add the DeepSeek R1 model. The current code is not easy to update.?

This PR is not about the deepseek models, we provider many integrations of deepseek in the 0.15.3 version.

Check the release note.

Additionally, how can I switch between DeepSeek-R1 and DeepSeek-V3 models within a session, rather than using different applications to implement the switch? I noticed that the chat window on the DeepSeek official website allows switching between DeepSeek-R1 and DeepSeek-V3

@MJSanfelippo
Copy link

Please merge this, we need this feature asap

2 similar comments
@Halfknow
Copy link

Please merge this, we need this feature asap

@liuzixiao666
Copy link

Please merge this, we need this feature asap

@Wu-Jiayang
Copy link
Contributor Author

@MJSanfelippo
Copy link

@crazywoola @takatost @laipz8200 @iamjoel @JohnJyong @zxhlyh

Owners of Dify, please merge and release this. It's holding us back from using Dify.

In the meantime, anyone know any other tools like Dify?

@Wu-Jiayang
Copy link
Contributor Author

maybe ragflow or fastgpt

@laipz8200 laipz8200 merged commit 423fb2d into langgenius:main Feb 11, 2025
6 checks passed
@cubxxw
Copy link

cubxxw commented Feb 11, 2025

lgtm

@bowenliang123
Copy link
Contributor

Great !

@MJSanfelippo
Copy link

@crazywoola when will this be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment