Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve selection of variable in workflow #15484

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

utsumi-fj
Copy link
Contributor

Summary

Fixes #14494
In the menu for selecting variables to be used in a workflow, mousedown event would cause the focus to be removed (blur event), so quick mouseup is needed to successfully select variables. This pull request fixes this behavior and makes it easier to select variables with touchpad and slow mouseup.

Screenshots

Operation movies:

Before After
https://drive.google.com/file/d/1gwQkgm-TKsj6D6190ouvKfD_qHxKrK68/view?usp=sharing https://drive.google.com/file/d/10-tKAMLIAJ8ch9MqYb0f_Pmszvccmm4T/view?usp=sharing

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Signed-off-by: Yuichiro Utsumi <utsumi.yuichiro@fujitsu.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Mar 11, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 11, 2025
@crazywoola crazywoola merged commit 71a5727 into langgenius:main Mar 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select input variable in Tools pannel
2 participants