Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove port expose on db #15286

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix: remove port expose on db #15286

merged 1 commit into from
Mar 10, 2025

Conversation

kurokobo
Copy link
Contributor

@kurokobo kurokobo commented Mar 8, 2025

Summary

Closes #15285

In the PR #13836 that introduced the plugin feature, the ports was added to the db in the docker-compose.yml, allowing PostgreSQL to be exposed outside the Docker host by default.

This configuration is unnecessary for typical self-hosting scenarios.

It simply increases the potential for unauthorized access to the database and attacks. Due to the high security risk, the any port should be kept private by default.

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 8, 2025
@kurokobo kurokobo mentioned this pull request Mar 8, 2025
5 tasks
@crazywoola crazywoola requested a review from Yeuoly March 9, 2025 02:44
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 10, 2025
@Yeuoly Yeuoly merged commit 269ba6a into langgenius:main Mar 10, 2025
8 checks passed
@kurokobo kurokobo deleted the db branch March 10, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL should not be exposed externally by default
2 participants