Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dataset pagination state keeps resetting when filters changed #15268

Merged
merged 2 commits into from
Mar 8, 2025
Merged

fix: dataset pagination state keeps resetting when filters changed #15268

merged 2 commits into from
Mar 8, 2025

Conversation

nht1206
Copy link
Contributor

@nht1206 nht1206 commented Mar 8, 2025 •
edited
Loading

Summary

The infinite scroll functionality breaks when filters (tags, keywords, or includeAll) change.

Fixes #15270

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 8, 2025
@nht1206 nht1206 force-pushed the fix/dataset-pagination-reset branch from ae0961e to f79d11f Compare March 8, 2025 08:45
@nht1206 nht1206 force-pushed the fix/dataset-pagination-reset branch from f79d11f to 4407093 Compare March 8, 2025 08:46
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 8, 2025
@crazywoola crazywoola merged commit c9e3c8b into langgenius:main Mar 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Dataset infinite scroll functionality breaks when filters change
2 participants
@nht1206 @crazywoola