Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix HTTP request node non 443 port SSL site inaccessible #13376

Merged
merged 3 commits into from
Feb 8, 2025
Merged

fix: Fix HTTP request node non 443 port SSL site inaccessible #13376

merged 3 commits into from
Feb 8, 2025

Conversation

h4ckdepy
Copy link
Contributor

@h4ckdepy h4ckdepy commented Feb 8, 2025

Summary

Fix the issue where HTTP request nodes cannot access SSL sites on ports other than 443.

Closes #12792

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@h4ckdepy
fix: To avoid the situation where SSL sites on non-443 ports cannot b…
64b4a51 
…e accessed when using HTTP request nodes.

To avoid the situation where SSL sites on non-443 ports cannot be accessed when using HTTP request nodes.
@h4ckdepy
Merge pull request #1 from h4ckdepy/h4ckdepy-patch-change-squid-conf
680cd8d 
fix: To avoid the situation where SSL sites on non-443 ports cannot b…
@h4ckdepy
Fix: To avoid the situation where SSL sites on non-443 ports cannot b…
02e1ae9 
…e accessed when using HTTP request nodes.

To avoid the situation where SSL sites on non-443 ports cannot be accessed when using HTTP request nodes.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Feb 8, 2025
laipz8200
laipz8200 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 8, 2025
@laipz8200 laipz8200 merged commit 6622c7f into langgenius:main Feb 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to respond normally to HTTPS requests that use ports other than 443
2 participants
@h4ckdepy @laipz8200