Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add think display for volcengine and generic openapi #13234

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Feb 5, 2025

Summary

Similar to #12949 and #13152, but for volcengine and generic openapi.

Theoritically, this could remove duplicated code in those two PRs, but sadly I don't have accounts and keys to test them... So I only add new code.

Close #13255

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... 图片
... 图片

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ⚙️ feat:model-runtime labels Feb 5, 2025
@crazywoola crazywoola added this to the deepseek milestone Feb 5, 2025
@crazywoola
Copy link
Member

crazywoola commented Feb 5, 2025

Does it resolve #13210 ? If so, please close the issue in the description.
Please run dev/reformat to fix the lint errors as well.

@xhebox
Copy link
Contributor Author

xhebox commented Feb 5, 2025

Does it resolve #13210 ? If so, please close the issue in the description. Please run dev/reformat to fix the lint errors as well.

It did not solve it completely. I think #13210 also requires dify to provide deepseek-r1 automatically (in the base list).

I still add the model by myself in the setting.

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Contributor Author

xhebox commented Feb 5, 2025

Does it resolve #13210 ? If so, please close the issue in the description. Please run dev/reformat to fix the lint errors as well.

Lint fixed.

@crazywoola crazywoola self-requested a review February 5, 2025 16:40
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2025
@crazywoola crazywoola merged commit 5a685f7 into langgenius:main Feb 6, 2025
6 checks passed
@xiaoyesoso
Copy link

May I ask when the official plan is to release a new version containing this feature? Looking forward to it~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add think display for volcengine and generic openapi
3 participants