Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dataset edit permissions #13223

Merged
merged 3 commits into from
Feb 6, 2025
Merged

fix: add dataset edit permissions #13223

merged 3 commits into from
Feb 6, 2025

Conversation

WTW0313
Copy link
Collaborator

@WTW0313 WTW0313 commented Feb 5, 2025

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. labels Feb 5, 2025
web/utils/permission.ts Outdated Show resolved Hide resolved
@WTW0313 WTW0313 marked this pull request as draft February 5, 2025 10:26
@WTW0313 WTW0313 marked this pull request as ready for review February 6, 2025 01:49
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2025
@WTW0313 WTW0313 merged commit 49b4144 into main Feb 6, 2025
8 checks passed
@WTW0313 WTW0313 deleted the fix/app-dataset-setting branch February 6, 2025 06:26
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Feb 8, 2025
* commit 'ca19bd31d42fb87c83b91541c473ebae85e9d14e': (99 commits)
  chore(*): Bump version to 0.15.3 (langgenius#13308)
  feat: add completion mode and context size options for LLM configuration (langgenius#13325)
  fix: Azure AI Foundry model cannot be used in the workflow (langgenius#13323)
  chore:improve thinking display for llm from xinference and ollama pro… (langgenius#13318)
  chore(*): Update style of thinking (langgenius#13319)
  Fix the problem of Workflow terminates after parallel tasks execution, merge node not triggered (langgenius#12498)
  chore: refactor the OpenAICompatible and improve thinking display (langgenius#13299)
  fix(credits): require model name equals (langgenius#13314)
  feat(model): add deepseek-r1 for openrouter (langgenius#13312)
  feat(credits): Allow to configure model-credit mapping (langgenius#13274)
  Update README_TR.md (langgenius#13294)
  feat: added a couple of models not defined in vertex ai, that were already … (langgenius#13296)
  feat:add think tag display for xinference deepseek r1 (langgenius#13291)
  fix: incorrect transferMethod assignment for remote file (langgenius#13286)
  feat: add deepseek models for volcengine provider (langgenius#13283)
  feat:add deepseek r1 think display for ollama provider (langgenius#13272)
  fix: add dataset edit permissions (langgenius#13223)
  chore(deps): bump katex from 0.16.10 to 0.16.21 in /web (langgenius#13270)
  Upgrade oracle models (langgenius#13174)
  feat(model_providers): Support deepseek-r1 for Nvidia Catalog (langgenius#13269)
  ...

# Conflicts:
#	api/Dockerfile
#	api/core/model_runtime/model_providers/openai/llm/o3-mini-2025-01-31.yaml
#	api/core/model_runtime/model_providers/openai/llm/o3-mini.yaml
#	api/poetry.lock
#	web/yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants