Unify plugin endpoint configuration for api and worker: migrate from PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY to PLUGIN_API_URL/PLUGIN_API_KEY

[BorisPolonsky]

Unify plugin endpoint configuration for api and worker: Substitute PLUGIN_API_URL and PLUGIN_API_KEY for PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY
This is an alternative solution to #13239, which does things the other way around.

Fixes #13113

Summary

PR #13055 introduces PLUGIN_API_URL and PLUGIN_API_KEY in docker-compose.yaml, which coexists with the original PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY (the ones that actually take effect) and caused confusions that ends up in InternalServerError (#12664). This PR unify the environment variables by migrating from PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY to PLUGIN_API_URL and PLUGIN_API_KEY in order to unify the configuration and fix the issues caused by this confusion, namely

• Fixes Inconsistency between docker-compose.yaml and api on specifying entrypoint for pluginDaemon in v1.0.0-beta.1 #13113

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before	After
...	...

Checklist

Important

Please review the checklist below before submitting your pull request.

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

[crazywoola]

Please fix the lint errors. :)

[BorisPolonsky]

Given that there's ongoing PR that works on ruff lint (#13193) and all of the python code remain untouched in this PR while ruff prompts

Would reformat: models/dataset.py
1 file would be reformatted, 1207 files already formatted`

It's unlikely to be caused by this PR. Shall we resolved this with a separate PR and proceed with this PR for now (or at least come to a conclusion whether it's a good idea to migrate environment variables first). @crazywoola

[crazywoola]

Let me see.

[BorisPolonsky]

Let me see.

We've located the source and issued a separate PR to resolve this. @crazywoola
#13221

[Yeuoly]

PLUGIN_API_URL is a little confusing, on daemon side, PLUGIN_API_URL can been considered as the endpoint of api service, but on api side, PLUGIN_API_URL looks like the endpoint of daemon service, and all the environments are placed at a single .env file , that's why we refactor it to PLUGIN_DAEMON_URL, I recommend just change them to PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY

[BorisPolonsky]

PLUGIN_API_URL is a little confused, on daemon side, PLUGIN_API_URL can been considered as the endpoint of api service, but on api side, PLUGIN_API_URL looks like the endpoint of daemon service, and all the environments are placed at a single .env file , that's why we refactor it to PLUGIN_DAEMON_URL, I recommend just change them to PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY.

I'm with the idea that PLUGIN_API_URL is confusing. This PR is issued just to speed up the process of decision as we are currently working on dify-helm for 1.0.0 compatibility and wanted to avoid possible breaking change in the future. We could come up with a different PR that simply reverts PLUGIN_API_URL and PLUGIN_API_KEY that we introduced in #13055 as they don't take effects actually.

[Yeuoly]

PLUGIN_API_URL is a little confused, on daemon side, PLUGIN_API_URL can been considered as the endpoint of api service, but on api side, PLUGIN_API_URL looks like the endpoint of daemon service, and all the environments are placed at a single .env file , that's why we refactor it to PLUGIN_DAEMON_URL, I recommend just change them to PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY.

I'm with the idea that PLUGIN_API_URL is confusing. This PR is issued just to speed up the process of decision as we are currently working on dify-helm for 1.0.0 compatibility and wanted to avoid possible breaking change in the future. We could come up with a different PR that simply reverts those to variables introduced in #13055 as they don't take effects actually.

PLUGIN_API_KEY could be reverted I think, we should unify them also in docker compose, and of course we should not bring breaking changes to helm

[Yeuoly]

You can rebase to plugins/beta to resolve the CI errors

[BorisPolonsky]

You can rebase to plugins/beta to resolve the CI errors

Resolved linting error stated above. I've also issued another PR that unify environment variables as PLUGIN_DAEMON_URL and PLUGIN_DAEMON_KEY in #13239.

[Yeuoly]

Resolved #13239

[bowenliang123]

Thumbs up for this.