Support referencing agent variables in agent tool form parameters #13166
+55
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low/nodes/if-else/default.ts file
dosubot
bot
added
the
size:L
5 tasks
dosubot
bot
added
🔨 feat:tools
Merged
5 tasks
crazywoola
requested changes
Feb 4, 2025
There was a problem hiding this comment.
It seems some changes already included in #13165, please remove those in this PR to make sure only related code is changed.
dosubot
bot
added
size:M
obadakhalili
commented
Feb 4, 2025
| app_id: str, | ||
| agent_tool: AgentToolEntity, | ||
| variables_inputs: Optional[Mapping[str, Any]] = None, | ||
| invoke_from: InvokeFrom = InvokeFrom.DEBUGGER, |
There was a problem hiding this comment.
I'm a bit skeptical of defining variables_inputs here, because this method is used in contexts where variables_inputs isn't available.
obadakhalili
commented
Feb 4, 2025
| @@ -102,6 +102,7 @@ export type FormShowOnObject = { | |||
|
|
|||
| export type CredentialFormSchemaBase = { | |||
| variable: string | |||
| inputs?: Array<{ name: string; value: string }> | |||
There was a problem hiding this comment.
to render a form with an input that accepts variables, the schema is changed to accept inputs property, variables might be a better name, but it is confusing next to variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
depends on #13165.
this PR proposes a change to support referencing agent variables in tool form parameters. the full context behind this work is explained here: #13080.
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods