-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support referencing agent variables in agent tool form parameters #13166
base: main
Are you sure you want to change the base?
Support referencing agent variables in agent tool form parameters #13166
Conversation
…low/nodes/if-else/default.ts file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems some changes already included in #13165, please remove those in this PR to make sure only related code is changed.
app_id: str, | ||
agent_tool: AgentToolEntity, | ||
variables_inputs: Optional[Mapping[str, Any]] = None, | ||
invoke_from: InvokeFrom = InvokeFrom.DEBUGGER, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit skeptical of defining variables_inputs
here, because this method is used in contexts where variables_inputs
isn't available.
@@ -102,6 +102,7 @@ export type FormShowOnObject = { | |||
|
|||
export type CredentialFormSchemaBase = { | |||
variable: string | |||
inputs?: Array<{ name: string; value: string }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to render a form with an input that accepts variables, the schema is changed to accept inputs
property, variables
might be a better name, but it is confusing next to variable
.
ec196ff
to
dc4f82b
Compare
…nd workflow/nodes/if-else/default.ts file" This reverts commit 3c04edd.
Style check / Web Style (pull_request) fails because it asks me to use type instead of interface, which seems to be a new rule, but the main branch ins't adhering to this rule yet, so applying it here will make the diff too large. |
Summary
depends on #13165.
this PR proposes a change to support referencing agent variables in tool form parameters. the full context behind this work is explained here: #13080.
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods