Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bedrock_endpoint_url #12838

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

2284730142
Copy link
Contributor

@2284730142 2284730142 commented Jan 18, 2025

add bedrock_endpoint_url for users who need a proxy

Summary

Added bedrock_endpoint_url configuration option to allow users to customize the AWS Bedrock endpoint URL. This change is primarily intended for:

  1. Users who need to access Bedrock services through a proxy
  2. Users utilizing private VPC endpoints
  3. Users who need to connect to Bedrock services in different regions

Motivation and Context

In certain enterprise environments, network security policies require accessing AWS Bedrock services through specific proxies or private endpoints. Adding this configuration option enhances system flexibility, enabling service usage across more scenarios.

Dependencies

  • No new dependencies added
  • Compatible with existing AWS Bedrock client configuration

Fixes #12926

Screenshots

| Before | After |
|image|image|

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

add bedrock_endpoint_url for users who need a proxy
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ⚙️ feat:model-runtime labels Jan 18, 2025
@crazywoola
Copy link
Member

Please link an existing issue or create an issue.:)

@2284730142
Copy link
Contributor Author

@crazywoola Thanks for the reminder! I've created an issue #12926 to track this feature request.

The issue describes the need for a custom Bedrock endpoint URL configuration in enterprise environments where direct access to AWS services is restricted by security policies. This enhancement would help users who:

  • Need to route traffic through corporate proxies
  • Use private VPC endpoints
  • Connect to different regional endpoints

I've updated the PR description to link to the issue using the "Fixes #12926" syntax. Let me know if you need any additional information or clarification.

@crazywoola
Copy link
Member

Please run ./dev/reformat to resolve the lint errors.

format code with ruff
@2284730142
Copy link
Contributor Author

@crazywoola

I have run ./dev/reformat to fix the code formatting issues and pushed the updates as suggested. Here's what I did:

  1. Ran ./dev/reformat for code formatting
  2. Committed and pushed the updated code

Please review again. Let me know if there's anything else that needs to be adjusted.

@crazywoola
Copy link
Member

These changes only applies for version under v1.0, we will release v1.0 soon. You might need to move these changes to this repo https://github.com/langgenius/dify-official-plugins as well.

@warren830
Copy link
Contributor

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2025
@crazywoola crazywoola merged commit 1a2523f into langgenius:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support customize AWS Bedrock endpoint URL
3 participants