Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct validation for agent node which is invoked before publishing the app #12805

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

kurokobo
Copy link
Contributor

Summary

This is for plugins/beta branch.

This PR corrects moreDataForCheckValid for the Agent node in useChecklistBeforePublish.

The checkValid method for Agent node requires a customized structure of the moreDataForCheckValid object, and this object is correctly created for the Agent node in the useChecklist.
However, this is not implemented in useChecklistBeforePublish.

This PR builds moreDataForCheckValid for Agent node useChecklistBeforePublish as well, ensuring that checkValid is executed correctly at the time of publication.

Closes #12804

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 16, 2025
@crazywoola crazywoola added this to the 1.0 milestone Jan 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2025
@crazywoola crazywoola merged commit b5accda into langgenius:plugins/beta Jan 21, 2025
3 checks passed
@kurokobo kurokobo deleted the agent branch January 21, 2025 03:53
@AndyMik90
Copy link

@crazywoola is this live on https://console-plugin.dify.dev/ ? I'm facing this issue.

@perzeuss
Copy link
Contributor

perzeuss commented Feb 2, 2025

Same here. Tried with both chatflow and workflow, can't publish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants