Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ci job to test template for docker compose #12514

Merged

Conversation

kurokobo
Copy link
Contributor

@kurokobo kurokobo commented Jan 8, 2025

Summary

This PR introduce new CI test in Style check to test compose file and its template are in sync.
This test fails if the docker-compose.yaml and docker-compose-template.yaml are not in sync,

  • Triggered if the changes are in:
    • docker/generate_docker_compose
    • docker/.env.example
    • docker/docker-compose-template.yaml
    • docker/docker-compose.yaml
  • Invokes generate_docker_compose
  • If any changes are detected by git diff, the test will be failed. If not, the test will be passed

Closes #12505

Demos

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Jan 8, 2025
@kurokobo kurokobo changed the title feat: add ci to test template for docker compose feat: add ci job to test template for docker compose Jan 8, 2025
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this great work!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2025
@laipz8200 laipz8200 merged commit 1b940e7 into langgenius:main Jan 8, 2025
4 checks passed
@kurokobo kurokobo deleted the new-ci-test-for-compose-template branch January 8, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some changes from several PRs will be lost due to generate_docker_compose
2 participants