Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reverse sync docker-compose-template.yaml #12509

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: Reverse sync docker-compose-template.yaml #12509

merged 2 commits into from
Jan 9, 2025
+11 −3

Conversation

fujita-h
Copy link
Contributor

@fujita-h fujita-h commented Jan 8, 2025

Summary

Fixes #12505

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@fujita-h fujita-h mentioned this pull request Jan 8, 2025
Closed
5 tasks
@kurokobo
Copy link
Contributor

kurokobo commented Jan 8, 2025

@fujita-h
The new CI has been merged, could you please rebase this PR to invoke new CI for testing?

@fujita-h fujita-h force-pushed the fix-reverse-sync-docker-compose branch from 78b7fa0 to dc9105c Compare January 8, 2025 16:19
@kurokobo
Copy link
Contributor

kurokobo commented Jan 8, 2025

💯 https://github.com/langgenius/dify/actions/runs/12674655368/job/35323842078

@kurokobo
Copy link
Contributor

kurokobo commented Jan 8, 2025

@crazywoola @laipz8200
LGTM for me 💯

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2025
@crazywoola crazywoola merged commit b4c1c2f into langgenius:main Jan 9, 2025
8 checks passed
@fujita-h fujita-h deleted the fix-reverse-sync-docker-compose branch January 9, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some changes from several PRs will be lost due to generate_docker_compose
3 participants
@fujita-h @kurokobo @crazywoola