Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12453 #12482 #12495

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix #12453 #12482 #12495

merged 2 commits into from
Jan 8, 2025

Conversation

JohnJyong
Copy link
Collaborator

@JohnJyong JohnJyong commented Jan 8, 2025

Summary

  1. fix create_by_text and create_by_file service api when dataset is empty
  2. fix dataset embedding dimensions issue

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

fix #12453
fix #12482

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 8, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@JohnJyong JohnJyong changed the title fix #12453 #11430 fix #12453 #12482 Jan 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2025
@crazywoola crazywoola merged commit bee32d9 into main Jan 8, 2025
8 checks passed
@crazywoola crazywoola deleted the fix/service-api-when-dataset-is-empty branch January 8, 2025 10:26
alexcodelf pushed a commit to alexcodelf/dify that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
2 participants