Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compose project name for docker compose #12451

Closed

Conversation

XenoAmess
Copy link

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 7, 2025
@crazywoola
Copy link
Member

Hello please open an issue first. :)

@kurokobo
Copy link
Contributor

kurokobo commented Jan 7, 2025

Related to: #8327 (comment)

Sorry, we can not accept this PR, because this changes may affect existing users who already start with the old compose configuration.

We decide to leave it as an optional with docker compose up -d -p dify.

So if we accept this PR, I think the default value should be docker to avoid affecting existing environment.

@crazywoola crazywoola closed this Jan 8, 2025
@XenoAmess
Copy link
Author

Related to: #8327 (comment)

Sorry, we can not accept this PR, because this changes may affect existing users who already start with the old compose configuration.
We decide to leave it as an optional with docker compose up -d -p dify.

So if we accept this PR, I think the default value should be docker to avoid affecting existing environment.

but logically you ARE dify, but NOT docker...
considering other guys doing such things too, that would be a disaster.
please consider this when enter next major update(when need not consider too many backward compa.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants