Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where TextGeneration component does not correctly clear input data. #12351

Merged

Conversation

Woo0ood
Copy link
Contributor

@Woo0ood Woo0ood commented Jan 3, 2025

Summary

Resolves #11849

This PR is a resubmission as requested, as part of the now-closed #11850 .

Fixed

  • Fix the issue where TextGeneration component does not correctly clear input data
    • Fixed the issue in the text generation application where the TextGeneration component did not properly reset references when clearing the form. This issue caused old form values to be automatically filled in upon re-entering data. Now, the form references are correctly reset after clearing, ensuring that new input data is not affected by previous values.

Modification Details

This section was automatically generated by GitHub Copilot actions.

This pull request includes changes to the web/app/components/share/text-generation/index.tsx file to improve the handling of state updates and references. The most important changes are the addition of the useCallback hook and the refactoring of the inputs state management.

Improvements to state management:

  • Added useCallback to memoize the setInputs function, ensuring that it does not get recreated on each render. (web/app/components/share/text-generation/index.tsx)
  • Refactored the inputs state management by introducing doSetInputs and inputsRef to keep the state and its reference in sync. (web/app/components/share/text-generation/index.tsx)

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Jan 3, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2025
@crazywoola crazywoola merged commit 682ebc5 into langgenius:main Jan 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Various Synchronization and Display Issues in Components
2 participants