Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Encode Chinese characters with Unicode before querying to match the Unicode encoded Chinese characters in the db #12337

Merged

Conversation

xhdd123321
Copy link
Contributor

@xhdd123321 xhdd123321 commented Jan 3, 2025

Summary

The Chinese characters in the inputs and outputs of the workflow table are stored in Unicode encoding, which prevents the search box from querying workflow run log in Chinese.I encoded the Chinese characters with Unicode before searching the table, so that a match can be hit normally.I have tested that this change will not affect language queries that are not encoded in Unicode.

image

Resolve #12039 I noticed that someone had mentioned this error before, but it was closed.

Screenshots

Before After
imageimage image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

…the Unicode encoded Chinese characters in the database
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 3, 2025
@crazywoola
Copy link
Member

Please fix the test.

@xhdd123321
Copy link
Contributor Author

请修复测试。

Fixed

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 3, 2025
@crazywoola crazywoola merged commit a5fb59b into langgenius:main Jan 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version: 0.8.3 get workflow_log, keyword is useless when using Chinese characters
2 participants