Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DocumentAddByFileApi miss data_source_type field but there is a mandatory value check #12273

Merged
merged 6 commits into from
Jan 2, 2025
Merged

fix: DocumentAddByFileApi miss data_source_type field but there is a mandatory value check #12273

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4be8587
修正 data_source 中确实 data_source_type 字段的问题
lyfuci Jan 1, 2025
3310b24
fit the python code style, add space after the colon mark of data_sou…
lyfuci Jan 1, 2025
733b39f
refer to DocumentUpdateByTextApi adjust the format
lyfuci Jan 1, 2025
074b49a
Merge branch 'langgenius:main' into fix-document-add-by-file-field-mi…
lyfuci Jan 2, 2025
7630d84
meet the ruff require format
lyfuci Jan 2, 2025
6f1de8d
fix the DocumentUpdateByFileApi for the same problem
lyfuci Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions api/controllers/service_api/dataset/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,10 @@ def post(self, tenant_id, dataset_id):
user=current_user,
source="datasets",
)
data_source = {"type": "upload_file", "info_list": {"file_info_list": {"file_ids": [upload_file.id]}}}
data_source = {
"type": "upload_file",
"info_list": {"data_source_type": "upload_file", "file_info_list": {"file_ids": [upload_file.id]}},
}
args["data_source"] = data_source
# validate args
knowledge_config = KnowledgeConfig(**args)
Expand Down Expand Up @@ -254,7 +257,10 @@ def post(self, tenant_id, dataset_id, document_id):
raise FileTooLargeError(file_too_large_error.description)
except services.errors.file.UnsupportedFileTypeError:
raise UnsupportedFileTypeError()
data_source = {"type": "upload_file", "info_list": {"file_info_list": {"file_ids": [upload_file.id]}}}
data_source = {
"type": "upload_file",
"info_list": {"data_source_type": "upload_file", "file_info_list": {"file_ids": [upload_file.id]}},
}
args["data_source"] = data_source
# validate args
args["original_document_id"] = str(document_id)
Expand Down
Loading