fix: default value of google storage sa to empty #12188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an error when using Default Service Account in Google Storage.
When using Default Service Account, the environment variable GOOGLE_STORAGE_SERVICE_ACCOUNT_JSON_BASE64 must be an empty string. However, even if an empty string was specified in .env, the default string was specified in docker-compose.yaml. Therefore, the default string was changed to the empty string.
Additional Information.
As an alternative fix, it is possible to change the default to be specified only when undefined, but since the scope of impact is large, this was addressed in this issue.
current style
SOME_VARIABLE: ${SOME_VARIABLE:-default}
alternative style
SOME_VARIABLE: ${SOME_VARIABLE-default}
see https://docs.docker.com/reference/compose-file/interpolation/
Screenshots
Checklist
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods