Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove ruff ignore SIM300 #11810

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: remove ruff ignore SIM300 #11810

merged 2 commits into from
Dec 19, 2024

Conversation

barabicu
Copy link
Contributor

@barabicu barabicu commented Dec 18, 2024 •
edited
Loading

Summary

Change to apply SIM300 in ruff and check that the test passes afterwards.
https://docs.astral.sh/ruff/rules/yoda-conditions/

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 18, 2024
@barabicu barabicu marked this pull request as draft December 18, 2024 12:39
@barabicu barabicu changed the title fix: remove ruff ignore SIM300 [WIP] fix: remove ruff ignore SIM300 Dec 18, 2024
@barabicu barabicu changed the title [WIP] fix: remove ruff ignore SIM300 fix: remove ruff ignore SIM300 Dec 18, 2024
@barabicu barabicu marked this pull request as ready for review December 18, 2024 14:01
@crazywoola
Copy link
Member

Please fix the lint.

@barabicu
Copy link
Contributor Author

OK, fix done.

@crazywoola crazywoola requested a review from laipz8200 December 19, 2024 09:50
bowenliang123
bowenliang123 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@crazywoola crazywoola merged commit d057067 into langgenius:main Dec 19, 2024
5 checks passed
jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
@barabicu
fix: remove ruff ignore SIM300 (langgenius#11810)
5a5c758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@bowenliang123 bowenliang123 bowenliang123 approved these changes

@laipz8200 laipz8200 Awaiting requested review from laipz8200

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barabicu @crazywoola @bowenliang123