Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhance file type detection in HTTP Request node #11797

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

tancheng33
Copy link
Contributor

@tancheng33 tancheng33 commented Dec 18, 2024

Summary

Enhances file type detection in the HTTP Request node by improving MIME type detection logic. The changes include:

  1. Added fallback mechanism for content type detection:

    • First tries Content-Type from response headers
    • Then attempts to guess type from URL using mimetypes
    • Finally defaults to "application/octet-stream" if no type can be determined
  2. Improved file handling in HTTP responses by properly checking both Content-Type headers and URL patterns

This change ensures more reliable file type detection when handling HTTP responses, particularly for file downloads where the Content-Type header might be missing or incorrect.

close #11459

Screenshots

image
Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 18, 2024
@crazywoola crazywoola requested a review from laipz8200 December 18, 2024 09:35
@crazywoola
Copy link
Member

Please fix the lint error, maybe you need to rebase the origin/main.

Signed-off-by: -LAN- <laipz8200@outlook.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@laipz8200 laipz8200 merged commit 4410479 into langgenius:main Dec 19, 2024
5 checks passed
jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
Signed-off-by: -LAN- <laipz8200@outlook.com>
Co-authored-by: 谭成 <tancheng.sh@chinatelecom.cn>
Co-authored-by: -LAN- <laipz8200@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the type guess in the HTTP Request Node
3 participants