Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak by pypdfium2 close(maybe) #11510 #11700

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 16, 2024

Summary

This patch fix a memory leak by updating the pypdfium2 version to latest. close #11510

how to trace the memory leak:

follow the article: https://pythonspeed.com/articles/python-server-memory-leaks/

  1. using filprofiler
  2. run the program python -m filprofiler run app.py
  3. another program run times python -m pytest api/tests/integration_tests/workflow

the memory profile show almost all memory cost from pypdfium2

image

search the net found these:
facebookresearch/nougat#110
https://forum.patagames.com/posts/t805-Memory-Leak-in-PDFDocument-Load-when-Pdfium-FPDF-LoadCustomDocument-returns-an-IntPtr-Zero

try to update the pypdfium2 version to latest

https://pyoven.org/package/pypdfium2?tab=versions

than do the steps again
new memory profile looks normal

image

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Dec 16, 2024
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 16, 2024
@laipz8200 laipz8200 merged commit efa8eb3 into langgenius:main Dec 16, 2024
7 checks passed
jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak
2 participants