add google_translate.difypkg #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svcvit
commented
Jan 23, 2025
svcvit
commented
LogicOber
suggested changes
Feb 8, 2025
There was a problem hiding this comment.
Hi @svcvit 👋 Thank you for your contribution and the time you’ve invested in this plugin! The plugin functions well overall, but it is recommended to provide:
- a more comprehensive usage guide in README.md and to elaborate on the required input keys (such as the text to be translated and the target language) as well as the response format in PRIVACY.md. This ensures users are informed about data handling. (Although this plugin seems easy to understand in use, completeness is necessary.)
- Additionally, a clear privacy policy statement should be included in PRIVACY.md.
🔥 I truly appreciate your time, and I hope your plugin gains more recognition!
|
@LogicOber Thanks! I've made the additions based on your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.