Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hy/chore with dify main #202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yihong0618
Copy link

core with main repo

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@Yeuoly
Copy link
Contributor

Yeuoly commented Feb 12, 2025

Hi, single PR can only contributes to one plugin, and it should be split to servals smalls

@yihong0618
Copy link
Author

Hi, single PR can only contributes to one plugin, and it should be split to servals smalls

Hi the change almost the same, more can check langgenius/dify#13518

@Yeuoly
Copy link
Contributor

Yeuoly commented Feb 12, 2025

Hi, single PR can only contributes to one plugin, and it should be split to servals smalls

Hi the change almost the same, more can check langgenius/dify#13518

I understand, but as you can see, after PR has been merged, a plugin will been packaged and uploaded to marketplace, we are planning to support multiple plugin changes in the same PR, but once an error occurs, just partial plugins succeed, It's hard to rollback changes, that's why only one plugin is supported.

@Yeuoly
Copy link
Contributor

Yeuoly commented Feb 12, 2025

BTW, please also bump the version in each manifest.yaml (not meta.version), it's helpful for version management.

@yihong0618
Copy link
Author

Hi, single PR can only contributes to one plugin, and it should be split to servals smalls

Hi the change almost the same, more can check langgenius/dify#13518

I understand, but as you can see, after PR has been merged, a plugin will been packaged and uploaded to marketplace, we are planning to support multiple plugin changes in the same PR, but once an error occurs, just partial plugins succeed, It's hard to rollback changes, that's why only one plugin is supported.

ok will do this tomorrow

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 force-pushed the hy/chore_with_dify_main branch from 312e4b2 to 0032553 Compare February 14, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants