-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds new JSON viewer #5407
Draft
anovazzi1
wants to merge
42
commits into
main
Choose a base branch
from
updateJsonView
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,156
−835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great thing to have! |
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
enhancement
New feature or request
labels
Jan 20, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 20, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 20, 2025
Cristhianzl
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 20, 2025
This commit adds a new component called JsonEditor, which allows users to edit JSON data. The component uses the JSONEditor library and provides options for customizing the editor's appearance and behavior. It also includes functionality for updating the edited data and triggering a callback when the data changes. The component is initialized with an initial data object and can be updated with new data through props. The component is designed to be reusable and can be easily integrated into other parts of the application.
The commit adds a new component called JsonEditor for editing JSON data. It replaces the previous JsonView component used for displaying JSON data. This change improves the functionality and user experience of the application.
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT MERGE
Don't Merge this PR
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr adds a new component called JsonEditor for editing JSON data. It replaces the previous JsonView component used for displaying JSON data. This change improves the functionality and user experience of the application.