-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Tighten up dependencies #4792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Nov 22, 2024
CodSpeed Performance ReportMerging #4792 will improve performances by 14.84%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ogabrielluiz
force-pushed
the
tighten-up-dependencies
branch
from
November 22, 2024 19:27
39487ee
to
9160d8e
Compare
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* take 1 WIP * remove firecrawl dep from langflow package, only usage appears to be in langflow-base * langchain-google-genai to 2.0.1 which is what we have now in the lock file * widen ranges based on old lock file * lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ignore-for-release
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've had a few cases where major releases in dependencies break langflow so we wanted to tighten up the ranges in the pyproject.tomls
Summary
This pull request focuses on updating the dependencies in the
pyproject.toml
files to include upper version constraints. This change aims to ensure compatibility and prevent potential issues with future major releases of these dependencies.Dependency updates:
pyproject.toml
: Added upper version constraints to all dependencies to ensure compatibility and prevent issues with future major releases.src/backend/base/pyproject.toml
: Added upper version constraints to all dependencies to ensure compatibility and prevent issues with future major releases.The strategy was to pin everything to a major version to match what poetry ^ does. In some cases, the uv.lock was already using a version higher than that so for those cases I fixed the ranges so that this PR does not change versions compared to
main
.Sanity check:
I ran uv sync against
main
then switched branches and ran uv sync again. Nothing changes: