Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tighten up dependencies #4792

Merged
merged 5 commits into from
Nov 22, 2024
Merged

chore: Tighten up dependencies #4792

merged 5 commits into from
Nov 22, 2024

Conversation

phact
Copy link
Collaborator

@phact phact commented Nov 22, 2024

Motivation

We've had a few cases where major releases in dependencies break langflow so we wanted to tighten up the ranges in the pyproject.tomls

Summary

This pull request focuses on updating the dependencies in the pyproject.toml files to include upper version constraints. This change aims to ensure compatibility and prevent potential issues with future major releases of these dependencies.

Dependency updates:

  • pyproject.toml: Added upper version constraints to all dependencies to ensure compatibility and prevent issues with future major releases.
  • src/backend/base/pyproject.toml: Added upper version constraints to all dependencies to ensure compatibility and prevent issues with future major releases.

The strategy was to pin everything to a major version to match what poetry ^ does. In some cases, the uv.lock was already using a version higher than that so for those cases I fixed the ranges so that this PR does not change versions compared to main.

Sanity check:

I ran uv sync against main then switched branches and ran uv sync again. Nothing changes:

$ git switch tighten-up-dependencies
Switched to branch 'tighten-up-dependencies'
Your branch is up to date with 'origin/tighten-up-dependencies'.
langflowtato@wezn:~/Desktop/langflow$ uv sync
Resolved 492 packages in 2ms
   Built langflow @ file:///home/tato/Desktop/langflow
   Built langflow-base @ file:///home/tato/Desktop/langflow/src/backend/base
Prepared 2 packages in 236ms
Uninstalled 2 packages in 0.52ms
Installed 2 packages in 0.77ms
 ~ langflow==1.1.0 (from file:///home/tato/Desktop/langflow)
 ~ langflow-base==0.1.0 (from file:///home/tato/Desktop/langflow/src/backend/base)

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 22, 2024
@phact phact requested a review from ogabrielluiz November 22, 2024 18:28
@phact phact self-assigned this Nov 22, 2024
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #4792 will improve performances by 14.84%

Comparing tighten-up-dependencies (9160d8e) with main (230a019)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main tighten-up-dependencies Change
test_successful_run_with_input_type_any 233 ms 202.9 ms +14.84%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2024
@ogabrielluiz ogabrielluiz force-pushed the tighten-up-dependencies branch from 39487ee to 9160d8e Compare November 22, 2024 19:27
@ogabrielluiz ogabrielluiz merged commit 061971f into main Nov 22, 2024
16 checks passed
@ogabrielluiz ogabrielluiz deleted the tighten-up-dependencies branch November 22, 2024 19:37
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* take 1 WIP

* remove firecrawl dep from langflow package, only usage appears to be in langflow-base

* langchain-google-genai to 2.0.1 which is what we have now in the lock file

* widen ranges based on old lock file

* lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants