chore: Add pyproject.toml configuration to ruff format command in Makefile #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- Makefile: Language not supported
CodSpeed Performance ReportMerging #4714 will not alter performanceComparing Summary
|
ogabrielluiz
changed the title
ogabrielluiz
force-pushed
the
add-flags-uv
branch
from
434ac53 to
68469bd
Compare
italojohnny
approved these changes
Nov 19, 2024
ogabrielluiz
force-pushed
the
add-flags-uv
branch
from
68469bd to
9d90fc9
Compare
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Nov 22, 2024
…efile (langflow-ai#4714) * Add pyproject.toml config flag to ruff commands in Makefile * Update ruff exclude path in pyproject.toml * Remove unused TYPE_CHECKING import from api_key.py * Remove redundant config flag from 'ruff check' command in Makefile
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…efile (langflow-ai#4714) * Add pyproject.toml config flag to ruff commands in Makefile * Update ruff exclude path in pyproject.toml * Remove unused TYPE_CHECKING import from api_key.py * Remove redundant config flag from 'ruff check' command in Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Makefile to include a configuration flag for ruff commands, allowing them to utilize the
pyproject.tomlfile for settings. This change enhances the flexibility and maintainability of the code formatting and linting processes.I did not add to check because there are a lot of errors so we should do it in a separate PR.