-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add Groq Model Constants #4689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groq models updated
edwinjosechittilappilly
requested review from
italojohnny,
ogabrielluiz and
NadirJ
November 18, 2024 22:38
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 18, 2024
CodSpeed Performance ReportMerging #4689 will not alter performanceComparing Summary
|
ogabrielluiz
requested changes
Nov 18, 2024
updated Groq Model list to be also a backup list if the API call fails, also at start.
format issue solved
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Nov 19, 2024
ogabrielluiz
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* upddate in groq models groq models updated * [autofix.ci] apply automated fixes * Update model_input_constants.py remove groq prefix * Update groq.py updated Groq Model list to be also a backup list if the API call fails, also at start. * Update groq.py format issue solved --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue temporarily for the GROQ Models not visible in Agent Component.
This pull request includes updates to the
GroqModel
class and its associated constants to improve the handling of model names and simplify the codebase. The most significant changes involve the introduction of a newGROQ_MODELS
constant and the removal of unnecessary methods for fetching model names dynamically.Updates to model constants and usage:
src/backend/base/langflow/base/models/groq_constants.py
: Introduced a new constantGROQ_MODELS
to replace the oldMODEL_NAMES
list and ensure reverse compatibility.Simplification of
GroqModel
class:src/backend/base/langflow/components/models/groq.py
: Updated theGroqModel
class to use the newGROQ_MODELS
constant for theoptions
parameter in theDropdownInput
field.src/backend/base/langflow/components/models/groq.py
: Removed theget_models
method and theupdate_build_config
method, as the model names are now statically defined in theGROQ_MODELS
constant.These changes streamline the code, making it easier to maintain and reducing the need for dynamic fetching of model names.